Robert Hensing 94916136dc Fix flake-c out of bounds access ... The explicit include is needed for clangd to not get confused somehow, which is also what threw me off initially and made me pick the wrong constructor. The (pointer, number, number) constructor first constructs a C string and then takes a substring from that, but we didn't specify that the buffer needs to be NUL-terminated, and then what would be the point of the size argument anyway... basic_string.h: > basic_string(const _Tp& __t, size_type __pos, size_type __n, > const _Alloc& __a = _Alloc()) > : basic_string(_S_to_string_view(__t).substr(__pos, __n), __a) { } Valgrind on nixops4/rust/nix-flake tests: ==1344422== Conditional jump or move depends on uninitialised value(s) ==1344422== at 0x48513E8: strlen (vg_replace_strmem.c:505) ==1344422== by 0x488E941: UnknownInlinedFun (char_traits.h:391) ==1344422== by 0x488E941: UnknownInlinedFun (string_view:141) ==1344422== by 0x488E941: UnknownInlinedFun (basic_string.h:790) ==1344422== by 0x488E941: nix_flake_reference_and_fragment_from_string (nix_api_flake.cc:81) ==1344422== by 0x127332: nix_flake::FlakeReference::parse_with_fragment (lib.rs:123)		2025-04-25 17:07:32 +02:00
..
.version	Add nix-flake-c, nix_flake_init_global, nix_flake_settings_new	2024-11-24 23:57:24 +01:00
meson.build	nix-fetchers-c: Init with settings object	2025-04-02 18:29:42 +02:00
nix-meson-build-support	rename: build-utils-meson -> nix-meson-build-support	2024-12-09 16:54:42 +01:00
nix_api_flake.cc	Fix flake-c out of bounds access	2025-04-25 17:07:32 +02:00
nix_api_flake.h	nix-flake-c: Add lock flags	2025-04-02 18:29:42 +02:00
nix_api_flake_internal.hh	nix-flake-c: Add basic flakeref parsing and locking	2025-04-02 18:29:42 +02:00
package.nix	nix-fetchers-c: Init with settings object	2025-04-02 18:29:42 +02:00