mirror of
https://github.com/NixOS/nix
synced 2025-06-24 22:11:15 +02:00
Handle race conditions in binary cache file creation by retrying with a new temporary name on EEXIST errors. Uses existing makeTempPath which already has an atomic counter.
156 lines
4.2 KiB
C++
156 lines
4.2 KiB
C++
#include "nix/store/local-binary-cache-store.hh"
|
|
#include "nix/store/globals.hh"
|
|
#include "nix/store/nar-info-disk-cache.hh"
|
|
#include "nix/util/signals.hh"
|
|
#include "nix/store/store-registration.hh"
|
|
|
|
#include <atomic>
|
|
|
|
namespace nix {
|
|
|
|
LocalBinaryCacheStoreConfig::LocalBinaryCacheStoreConfig(
|
|
std::string_view scheme,
|
|
PathView binaryCacheDir,
|
|
const StoreReference::Params & params)
|
|
: Store::Config{params}
|
|
, BinaryCacheStoreConfig{params}
|
|
, binaryCacheDir(binaryCacheDir)
|
|
{
|
|
}
|
|
|
|
|
|
std::string LocalBinaryCacheStoreConfig::doc()
|
|
{
|
|
return
|
|
#include "local-binary-cache-store.md"
|
|
;
|
|
}
|
|
|
|
|
|
struct LocalBinaryCacheStore :
|
|
virtual BinaryCacheStore
|
|
{
|
|
using Config = LocalBinaryCacheStoreConfig;
|
|
|
|
ref<Config> config;
|
|
|
|
LocalBinaryCacheStore(ref<Config> config)
|
|
: Store{*config}
|
|
, BinaryCacheStore{*config}
|
|
, config{config}
|
|
{
|
|
init();
|
|
}
|
|
|
|
void init() override;
|
|
|
|
std::string getUri() override
|
|
{
|
|
return "file://" + config->binaryCacheDir;
|
|
}
|
|
|
|
protected:
|
|
|
|
bool fileExists(const std::string & path) override;
|
|
|
|
void upsertFile(const std::string & path,
|
|
std::shared_ptr<std::basic_iostream<char>> istream,
|
|
const std::string & mimeType) override
|
|
{
|
|
auto path2 = config->binaryCacheDir + "/" + path;
|
|
|
|
/* Retry loop for handling race conditions */
|
|
while (true) {
|
|
Path tmp = makeTempPath(dirOf(path2), baseNameOf(path2) + ".tmp");
|
|
AutoDelete del(tmp, false);
|
|
|
|
StreamToSourceAdapter source(istream);
|
|
try {
|
|
writeFile(tmp, source);
|
|
} catch (Error & e) {
|
|
e.addTrace({}, "while writing to temporary file '%s' for '%s'", tmp, path2);
|
|
}
|
|
|
|
try {
|
|
std::filesystem::rename(tmp, path2);
|
|
del.cancel();
|
|
break; /* Success! */
|
|
} catch (std::filesystem::filesystem_error & e) {
|
|
if (e.code() == std::errc::file_exists) {
|
|
/* Race condition: another process created the same file.
|
|
Try again with a different name. */
|
|
continue;
|
|
}
|
|
throw SysError("renaming '%s' to '%s'", tmp, path2);
|
|
}
|
|
}
|
|
}
|
|
|
|
void getFile(const std::string & path, Sink & sink) override
|
|
{
|
|
try {
|
|
readFile(config->binaryCacheDir + "/" + path, sink);
|
|
} catch (SysError & e) {
|
|
if (e.errNo == ENOENT)
|
|
throw NoSuchBinaryCacheFile("file '%s' does not exist in binary cache", path);
|
|
throw;
|
|
}
|
|
}
|
|
|
|
StorePathSet queryAllValidPaths() override
|
|
{
|
|
StorePathSet paths;
|
|
|
|
for (auto & entry : DirectoryIterator{config->binaryCacheDir}) {
|
|
checkInterrupt();
|
|
auto name = entry.path().filename().string();
|
|
if (name.size() != 40 ||
|
|
!hasSuffix(name, ".narinfo"))
|
|
continue;
|
|
paths.insert(parseStorePath(
|
|
storeDir + "/" + name.substr(0, name.size() - 8)
|
|
+ "-" + MissingName));
|
|
}
|
|
|
|
return paths;
|
|
}
|
|
|
|
std::optional<TrustedFlag> isTrustedClient() override
|
|
{
|
|
return Trusted;
|
|
}
|
|
};
|
|
|
|
void LocalBinaryCacheStore::init()
|
|
{
|
|
createDirs(config->binaryCacheDir + "/nar");
|
|
createDirs(config->binaryCacheDir + "/" + realisationsPrefix);
|
|
if (config->writeDebugInfo)
|
|
createDirs(config->binaryCacheDir + "/debuginfo");
|
|
createDirs(config->binaryCacheDir + "/log");
|
|
BinaryCacheStore::init();
|
|
}
|
|
|
|
bool LocalBinaryCacheStore::fileExists(const std::string & path)
|
|
{
|
|
return pathExists(config->binaryCacheDir + "/" + path);
|
|
}
|
|
|
|
StringSet LocalBinaryCacheStoreConfig::uriSchemes()
|
|
{
|
|
if (getEnv("_NIX_FORCE_HTTP") == "1")
|
|
return {};
|
|
else
|
|
return {"file"};
|
|
}
|
|
|
|
ref<Store> LocalBinaryCacheStoreConfig::openStore() const {
|
|
return make_ref<LocalBinaryCacheStore>(ref{
|
|
// FIXME we shouldn't actually need a mutable config
|
|
std::const_pointer_cast<LocalBinaryCacheStore::Config>(shared_from_this())
|
|
});
|
|
}
|
|
|
|
static RegisterStoreImplementation<LocalBinaryCacheStore::Config> regLocalBinaryCacheStore;
|
|
|
|
}
|