wroclaw-git-backups/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-06-29 06:21:14 +02:00
Code Activity

fix(treewide): remove unnecessary copying in range for loops

Browse source 
This gets rid of unnecessary copies in range-based-for loops and
local variables, when they are used solely as `const &`.

Also added a fixme comment about a suspicious move out of const,
which might not be intended.
This commit is contained in:
Sergei Zimmerman 2024-11-24 01:05:08 +03:00
parent 4fc5295328
commit fafaec5ac3
20 changed files with 25 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libutil/url.cc
View file

@ -77,7 +77,7 @@ std::map<std::string, std::string> decodeQuery(const std::string & query)
{
std::map<std::string, std::string> result;
for (auto s : tokenizeString<Strings>(query, "&")) {
for (const auto & s : tokenizeString<Strings>(query, "&")) {
auto e = s.find('=');
if (e == std::string::npos) {
warn("dubious URI query '%s' is missing equal sign '%s', ignoring", s, "=");