From 6b987206ce51839a41cd0540236e5f5ecdc6940e Mon Sep 17 00:00:00 2001 From: Mike Kusold Date: Mon, 20 Jan 2025 11:04:53 -0700 Subject: [PATCH 1/2] Add unit of measurement for download-buffer-size I started getting these warnings `warning: download buffer is full; consider increasing the 'download-buffer-size' setting` but the documentation does not make it obvious what unit of measurement it accepts. --- src/libstore/filetransfer.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libstore/filetransfer.hh b/src/libstore/filetransfer.hh index d836ab2c4..e9a166af7 100644 --- a/src/libstore/filetransfer.hh +++ b/src/libstore/filetransfer.hh @@ -50,8 +50,9 @@ struct FileTransferSettings : Config Setting downloadBufferSize{this, 64 * 1024 * 1024, "download-buffer-size", R"( - The size of Nix's internal download buffer during `curl` transfers. If data is + The size of Nix's internal download buffer in bytes during `curl` transfers. If data is not processed quickly enough to exceed the size of this buffer, downloads may stall. + The default is 67108864 (64MB). )"}; }; From f0c209fb14cb511370ea2b7787d9a8dd90070162 Mon Sep 17 00:00:00 2001 From: Mike Kusold Date: Mon, 20 Jan 2025 11:32:47 -0700 Subject: [PATCH 2/2] Use standardize units for megabytes Co-authored-by: Eelco Dolstra --- src/libstore/filetransfer.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstore/filetransfer.hh b/src/libstore/filetransfer.hh index e9a166af7..43a384d71 100644 --- a/src/libstore/filetransfer.hh +++ b/src/libstore/filetransfer.hh @@ -52,7 +52,7 @@ struct FileTransferSettings : Config R"( The size of Nix's internal download buffer in bytes during `curl` transfers. If data is not processed quickly enough to exceed the size of this buffer, downloads may stall. - The default is 67108864 (64MB). + The default is 67108864 (64 MiB). )"}; };