diff --git a/doc/manual/rl-next/outpath-and-sourceinfo-fixes.md b/doc/manual/rl-next/outpath-and-sourceinfo-fixes.md new file mode 100644 index 000000000..479a2f5cb --- /dev/null +++ b/doc/manual/rl-next/outpath-and-sourceinfo-fixes.md @@ -0,0 +1,17 @@ +--- +synopsis: Non-flake inputs now contain a `sourceInfo` attribute +issues: 13164 +prs: 13170 +--- + +Flakes have always a `sourceInfo` attribute which describes the source of the flake. +The `sourceInfo.outPath` is often identical to the flake's `outPath`, however it can differ when the flake is located in a subdirectory of its source. + +Non-flake inputs (i.e. inputs with `flake = false`) can also be located at some path _within_ a wider source. +This usually happens when defining a relative path input within the same source as the parent flake, e.g. `inputs.foo.url = ./some-file.nix`. +Such relative inputs will now inherit their parent's `sourceInfo`. + +This also means it is now possible to use `?dir=subdir` on non-flake inputs. + +This iterates on the work done in 2.26 to improve relative path support ([#10089](https://github.com/NixOS/nix/pull/10089)), +and resolves a regression introduced in 2.28 relating to nested relative path inputs ([#13164](https://github.com/NixOS/nix/issues/13164)). diff --git a/src/libflake/call-flake.nix b/src/libflake/call-flake.nix index fe326291f..ed7947e06 100644 --- a/src/libflake/call-flake.nix +++ b/src/libflake/call-flake.nix @@ -39,24 +39,16 @@ let allNodes = mapAttrs ( key: node: let + hasOverride = overrides ? ${key}; + isRelative = node.locked.type or null == "path" && builtins.substring 0 1 node.locked.path != "/"; parentNode = allNodes.${getInputByPath lockFile.root node.parent}; - flakeDir = - let - dir = overrides.${key}.dir or node.locked.path or ""; - parentDir = parentNode.flakeDir; - in - if node ? parent then parentDir + ("/" + dir) else dir; - sourceInfo = - if overrides ? ${key} then + if hasOverride then overrides.${key}.sourceInfo - else if node.locked.type == "path" && builtins.substring 0 1 node.locked.path != "/" then + else if isRelative then parentNode.sourceInfo - // { - outPath = parentNode.sourceInfo.outPath + ("/" + flakeDir); - } else # FIXME: remove obsolete node.info. # Note: lock file entries are always final. @@ -64,7 +56,11 @@ let subdir = overrides.${key}.dir or node.locked.dir or ""; - outPath = sourceInfo + ((if subdir == "" then "" else "/") + subdir); + outPath = + if !hasOverride && isRelative then + parentNode.outPath + (if node.locked.path == "" then "" else "/" + node.locked.path) + else + sourceInfo.outPath + (if subdir == "" then "" else "/" + subdir); flake = import (outPath + "/flake.nix"); @@ -99,9 +95,9 @@ let assert builtins.isFunction flake.outputs; result else - sourceInfo; + sourceInfo // { inherit sourceInfo outPath; }; - inherit flakeDir sourceInfo; + inherit outPath sourceInfo; } ) lockFile.nodes; diff --git a/tests/functional/flakes/non-flake-inputs.sh b/tests/functional/flakes/non-flake-inputs.sh index f5e12cd01..05e656042 100644 --- a/tests/functional/flakes/non-flake-inputs.sh +++ b/tests/functional/flakes/non-flake-inputs.sh @@ -37,11 +37,20 @@ cat > "$flake3Dir/flake.nix" <flake.nix <nested-flake1/flake.nix <nested-flake1/nested-flake2/flake.nix <