From ed13cf05a224a08e4f120e0c932289db2d20be84 Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Sun, 7 Apr 2024 16:31:57 +0200 Subject: [PATCH] build-hook: Allow empty Like always declining; local builds only, as can be inferred from the docs. (Not worth spending too many words on this pretty obvious behavior, I think. Also, plans to remove it? https://github.com/NixOS/nix/issues/1221) --- src/libstore/build/derivation-goal.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstore/build/derivation-goal.cc b/src/libstore/build/derivation-goal.cc index 29bf2852f..4d4342996 100644 --- a/src/libstore/build/derivation-goal.cc +++ b/src/libstore/build/derivation-goal.cc @@ -1138,7 +1138,7 @@ void DerivationGoal::resolvedFinished() HookReply DerivationGoal::tryBuildHook() { - if (!worker.tryBuildHook || !useDerivation) return rpDecline; + if (settings.buildHook.get().empty() || !worker.tryBuildHook || !useDerivation) return rpDecline; if (!worker.hook) worker.hook = std::make_unique();