1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-07-07 01:51:47 +02:00

Apply suggestions from code review

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
This commit is contained in:
John Ericson 2024-07-04 17:48:27 -04:00 committed by GitHub
parent b0bc2a97bf
commit e4056b9afd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 6 additions and 10 deletions

View file

@ -69,7 +69,7 @@ headers = [config_h] + files(
'nix_api_value.h',
)
# TODO don't install this once tests don't use it.
# TODO move this header to libexpr, maybe don't use it in tests?
headers += files('nix_api_expr_internal.h')
subdir('build-utils-meson/export-all-symbols')

View file

@ -1,7 +1,6 @@
{ lib
, stdenv
, mkMesonDerivation
, releaseTools
, meson
, ninja

View file

@ -61,7 +61,7 @@ headers = [config_h] + files(
'nix_api_store.h',
)
# TODO don't install this once tests don't use it.
# TODO don't install this once tests don't use it and/or move the header into `libstore`, non-`c`
headers += files('nix_api_store_internal.h')
subdir('build-utils-meson/export-all-symbols')

View file

@ -118,7 +118,8 @@ busybox = find_program(get_option('sandbox-shell'), required : false)
if get_option('embedded-sandbox-shell')
# This one goes in config.h
# The path to busybox is passed as a -D flag when compiling this_library.
# Idk why, ask the old buildsystem.
# This solution is inherited from the old make buildsystem
# TODO: do this differently?
configdata.set('HAVE_EMBEDDED_SANDBOX_SHELL', 1)
hexdump = find_program('hexdump', native : true)
embedded_sandbox_shell_gen = custom_target(