From cef22abacd2af923eab68faf84072b16bfbeac6c Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Fri, 9 May 2025 17:00:30 -0400 Subject: [PATCH] Apply suggestions from code review --- doc/manual/source/release-notes-determinate/changes.md | 4 ++-- doc/manual/source/release-notes-determinate/rl-3.5.1.md | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/manual/source/release-notes-determinate/changes.md b/doc/manual/source/release-notes-determinate/changes.md index 7f9322936..b09604491 100644 --- a/doc/manual/source/release-notes-determinate/changes.md +++ b/doc/manual/source/release-notes-determinate/changes.md @@ -22,7 +22,7 @@ This section lists the differences between upstream Nix 2.28 and Determinate Nix -* Deprecate upgrade-nix command by @gustavderdrache in [DeterminateSystems/nix-src#55](https://github.com/DeterminateSystems/nix-src/pull/55) +* Deprecate upgrade-nix command in favor of `determinate-nixd upgrade`, by @gustavderdrache in [DeterminateSystems/nix-src#55](https://github.com/DeterminateSystems/nix-src/pull/55) * Lazy trees v2 by @edolstra in [DeterminateSystems/nix-src#27](https://github.com/DeterminateSystems/nix-src/pull/27) @@ -30,4 +30,4 @@ This section lists the differences between upstream Nix 2.28 and Determinate Nix * Canonicalize flake input URLs before checking flake.lock file staleness, for dealing with `dir` in URL-style flakerefs by @edolstra in [DeterminateSystems/nix-src#57](https://github.com/DeterminateSystems/nix-src/pull/57) -* Improve build failure error messages by @edolstra in [DeterminateSystems/nix-src#58](https://github.com/DeterminateSystems/nix-src/pull/58) +* Improved the build failure and dependency failure error messages to include output paths, by @edolstra in [DeterminateSystems/nix-src#58](https://github.com/DeterminateSystems/nix-src/pull/58) diff --git a/doc/manual/source/release-notes-determinate/rl-3.5.1.md b/doc/manual/source/release-notes-determinate/rl-3.5.1.md index 49f8f9221..0ebd7625a 100644 --- a/doc/manual/source/release-notes-determinate/rl-3.5.1.md +++ b/doc/manual/source/release-notes-determinate/rl-3.5.1.md @@ -3,8 +3,7 @@ * Based on [upstream Nix 2.28.3](../release-notes/rl-2.28.md). ## What's Changed -* Deprecate upgrade-nix command by @gustavderdrache in [DeterminateSystems/nix-src#55](https://github.com/DeterminateSystems/nix-src/pull/55) -* Update flake.lock in light of recent change by @lucperkins in [DeterminateSystems/nix-src#54](https://github.com/DeterminateSystems/nix-src/pull/54) +* Deprecate upgrade-nix command in favor of `determinate-nixd upgrade`, by @gustavderdrache in [DeterminateSystems/nix-src#55](https://github.com/DeterminateSystems/nix-src/pull/55) * Lazy trees v2 by @edolstra in [DeterminateSystems/nix-src#27](https://github.com/DeterminateSystems/nix-src/pull/27) * Improve lazy trees backward compatibility by @edolstra in [DeterminateSystems/nix-src#56](https://github.com/DeterminateSystems/nix-src/pull/56) * Canonicalize flake input URLs before checking flake.lock file staleness, for dealing with `dir` in URL-style flakerefs by @edolstra in [DeterminateSystems/nix-src#57](https://github.com/DeterminateSystems/nix-src/pull/57)