From c30b5d8a0bc7766e55b5254c75b264597bd2935e Mon Sep 17 00:00:00 2001 From: John Ericson Date: Mon, 11 Dec 2023 13:18:34 -0500 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com> --- src/libstore/local-overlay-store.hh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libstore/local-overlay-store.hh b/src/libstore/local-overlay-store.hh index 060ca37c3..64ed2f20a 100644 --- a/src/libstore/local-overlay-store.hh +++ b/src/libstore/local-overlay-store.hh @@ -24,7 +24,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig const PathSetting upperLayer{(StoreConfig*) this, "", "upper-layer", R"( - Must be used as OverlayFS upper layer for this store's store dir. + Directory containing the OverlayFS upper layer for this store's store dir. )"}; Setting checkMount{(StoreConfig*) this, true, "check-mount", @@ -60,6 +60,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig std::string doc() override; +protected: /** * Given a store path, get its location (if it is exists) in the * upper layer of the overlayfs. @@ -167,7 +168,7 @@ private: * Deduplicate by removing store objects from the upper layer that * are now in the lower layer. * - * This implementation will not cause duplications, but addition of + * Operations on a layered store will not cause duplications, but addition of * new store objects to the lower layer can instill induce them * (there is no way to prevent that). This cleans up those * duplications.