From 619b496317b81dd8c3979621a6fe4485c7b88cd6 Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Fri, 9 May 2025 14:31:58 -0400 Subject: [PATCH 1/2] Fix release notes * Stop aggressively deleting all the newlines --- .github/release-notes.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/release-notes.sh b/.github/release-notes.sh index 3fe3f6b17..9937c18cf 100755 --- a/.github/release-notes.sh +++ b/.github/release-notes.sh @@ -24,7 +24,7 @@ gh api "/repos/${GITHUB_REPOSITORY}/releases/generate-notes" \ trim_trailing_newlines() { local text text="$(cat)" - echo -n "${text//$'\n'}" + echo -n "${text}" } linkify_gh() { From 220fa1e4e486e859d11bbd8936d03f0c64ad18a8 Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Fri, 9 May 2025 16:02:18 -0400 Subject: [PATCH 2/2] Split the release notes into another commit --- .github/workflows/propose-release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/propose-release.yml b/.github/workflows/propose-release.yml index c01167994..82407abe7 100644 --- a/.github/workflows/propose-release.yml +++ b/.github/workflows/propose-release.yml @@ -26,6 +26,7 @@ jobs: extra-commands-early: | echo ${{ inputs.version }} > .version-determinate git add .version-determinate + git commit -m "Set .version-determinate to ${{ inputs.version }}" || true ./.github/release-notes.sh git add doc - git commit -m "Set .version-determinate to ${{ inputs.version }}" || true + git commit -m "Generare release notes for ${{ inputs.version }}" || true