wroclaw-git-backups/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-06-29 19:03:16 +02:00
Code Activity

Put worker protocol items inside a WorkerProto struct

Browse source 
See API docs on that struct for why. The pasing as as template argument
doesn't yet happen in that commit, but will instead happen in later
commit.

Also make `WorkerOp` (now `Op`) and enum struct. This led us to catch
that two operations were not handled!

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
This commit is contained in:
John Ericson 2023-05-26 11:07:25 -04:00
parent 469d06f9bc
commit 95eae0c002
12 changed files with 327 additions and 273 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/nix-store/nix-store.cc
View file

@ -850,7 +850,7 @@ static void opServe(Strings opFlags, Strings opArgs)
case cmdQueryValidPaths: {
bool lock = readInt(in);
bool substitute = readInt(in);
auto paths = WorkerProto<StorePathSet>::read(*store, in);
auto paths = WorkerProto::Serialise<StorePathSet>::read(*store, in);
if (lock && writeAllowed)
for (auto & path : paths)
store->addTempRoot(path);
@ -859,19 +859,19 @@ static void opServe(Strings opFlags, Strings opArgs)
store->substitutePaths(paths);
}
workerProtoWrite(*store, out, store->queryValidPaths(paths));
WorkerProto::write(*store, out, store->queryValidPaths(paths));
break;
}
case cmdQueryPathInfos: {
auto paths = WorkerProto<StorePathSet>::read(*store, in);
auto paths = WorkerProto::Serialise<StorePathSet>::read(*store, in);
// !!! Maybe we want a queryPathInfos?
for (auto & i : paths) {
try {
auto info = store->queryPathInfo(i);
out << store->printStorePath(info->path)
<< (info->deriver ? store->printStorePath(*info->deriver) : "");
workerProtoWrite(*store, out, info->references);
WorkerProto::write(*store, out, info->references);
// !!! Maybe we want compression?
out << info->narSize // downloadSize
<< info->narSize;
@ -899,7 +899,7 @@ static void opServe(Strings opFlags, Strings opArgs)
case cmdExportPaths: {
readInt(in); // obsolete
store->exportPaths(WorkerProto<StorePathSet>::read(*store, in), out);
store->exportPaths(WorkerProto::Serialise<StorePathSet>::read(*store, in), out);
break;
}
@ -945,7 +945,7 @@ static void opServe(Strings opFlags, Strings opArgs)
DrvOutputs builtOutputs;
for (auto & [output, realisation] : status.builtOutputs)
builtOutputs.insert_or_assign(realisation.id, realisation);
workerProtoWrite(*store, out, builtOutputs);
WorkerProto::write(*store, out, builtOutputs);
}
break;
@ -954,9 +954,9 @@ static void opServe(Strings opFlags, Strings opArgs)
case cmdQueryClosure: {
bool includeOutputs = readInt(in);
StorePathSet closure;
store->computeFSClosure(WorkerProto<StorePathSet>::read(*store, in),
store->computeFSClosure(WorkerProto::Serialise<StorePathSet>::read(*store, in),
closure, false, includeOutputs);
workerProtoWrite(*store, out, closure);
WorkerProto::write(*store, out, closure);
break;
}
@ -971,7 +971,7 @@ static void opServe(Strings opFlags, Strings opArgs)
};
if (deriver != "")
info.deriver = store->parseStorePath(deriver);
info.references = WorkerProto<StorePathSet>::read(*store, in);
info.references = WorkerProto::Serialise<StorePathSet>::read(*store, in);
in >> info.registrationTime >> info.narSize >> info.ultimate;
info.sigs = readStrings<StringSet>(in);
info.ca = ContentAddress::parseOpt(readString(in));