From 923cbea2af8eb1ccbd29b6b3542c974081bdddc1 Mon Sep 17 00:00:00 2001
From: Robert Hensing <robert@roberthensing.nl>
Date: Tue, 23 Apr 2024 18:07:45 +0200
Subject: [PATCH] builtins.warn: Use logWarning

Constructing ErrorInfo is a little awkward for now, but this does
produce a richer log entry.
---
 src/libexpr/primops.cc | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/libexpr/primops.cc b/src/libexpr/primops.cc
index 9319709c1..c20e0c359 100644
--- a/src/libexpr/primops.cc
+++ b/src/libexpr/primops.cc
@@ -1046,10 +1046,20 @@ static RegisterPrimOp primop_trace({
 static void prim_warn(EvalState & state, const PosIdx pos, Value * * args, Value & v)
 {
     state.forceValue(*args[0], pos);
-    if (args[0]->type() == nString)
-        printMsg(lvlWarn, ANSI_WARNING "warning:" ANSI_NORMAL " %1%", args[0]->string_view());
-    else
-        printMsg(lvlWarn, ANSI_WARNING "warning:" ANSI_NORMAL " %1%", ValuePrinter(state, *args[0]));
+
+    {
+        BaseError msg(args[0]->type() == nString
+                ? std::string(args[0]->string_view())
+                : ({
+                    std::stringstream s;
+                    s << ValuePrinter(state, *args[0]);
+                    s.str();
+                }));
+        msg.atPos(state.positions[pos]);
+        auto info = msg.info();
+        info.level = lvlWarn;
+        logWarning(info);
+    }
 
     if (evalSettings.builtinsAbortOnWarn) {
         state.error<Abort>("aborting to reveal stack trace of warning, as abort-on-warn is set").debugThrow();