1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-06-29 23:13:14 +02:00

Merge pull request #13299 from xokdvium/restore-packaging-overriding

flake: Restore `packaging-overriding` check
This commit is contained in:
John Ericson 2025-05-29 22:31:15 -04:00 committed by GitHub
commit 81f5d6763d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -220,28 +220,24 @@
This shouldn't build anything significant; just check that things This shouldn't build anything significant; just check that things
(including derivations) are _set up_ correctly. (including derivations) are _set up_ correctly.
*/ */
# Disabled due to a bug in `testEqualContents` (see packaging-overriding =
# https://github.com/NixOS/nix/issues/12690). let
/* pkgs = nixpkgsFor.${system}.native;
packaging-overriding = nix = self.packages.${system}.nix;
let in
pkgs = nixpkgsFor.${system}.native; assert (nix.appendPatches [ pkgs.emptyFile ]).libs.nix-util.src.patches == [ pkgs.emptyFile ];
nix = self.packages.${system}.nix; if pkgs.stdenv.buildPlatform.isDarwin then
in lib.warn "packaging-overriding check currently disabled because of a permissions issue on macOS" pkgs.emptyFile
assert (nix.appendPatches [ pkgs.emptyFile ]).libs.nix-util.src.patches == [ pkgs.emptyFile ]; else
if pkgs.stdenv.buildPlatform.isDarwin then # If this fails, something might be wrong with how we've wired the scope,
lib.warn "packaging-overriding check currently disabled because of a permissions issue on macOS" pkgs.emptyFile # or something could be broken in Nixpkgs.
else pkgs.testers.testEqualContents {
# If this fails, something might be wrong with how we've wired the scope, assertion = "trivial patch does not change source contents";
# or something could be broken in Nixpkgs. expected = "${./.}";
pkgs.testers.testEqualContents { actual =
assertion = "trivial patch does not change source contents"; # Same for all components; nix-util is an arbitrary pick
expected = "${./.}"; (nix.appendPatches [ pkgs.emptyFile ]).libs.nix-util.src;
actual = };
# Same for all components; nix-util is an arbitrary pick
(nix.appendPatches [ pkgs.emptyFile ]).libs.nix-util.src;
};
*/
} }
// (lib.optionalAttrs (builtins.elem system linux64BitSystems)) { // (lib.optionalAttrs (builtins.elem system linux64BitSystems)) {
dockerImage = self.hydraJobs.dockerImage.${system}; dockerImage = self.hydraJobs.dockerImage.${system};