wroclaw-git-backups/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-07-08 06:53:54 +02:00
Code Activity

rl-next: Add top 10 by +1 reactions on PRs

Browse source 
We should use a metric that weighs the related issues.
Counterbalancing time doesn't make much sense to me.
If it's around for longer, the fix will be relevant to more people.
This commit is contained in:
Robert Hensing 2024-07-25 05:57:53 +02:00
parent 8a7e31362a
commit 7275d68d3b
7 changed files with 94 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/manual/rl-next/11086-eval-cache-fix-cache-regressions.md Normal file
View file

@ -0,0 +1,14 @@
---
synopsis: "Eval cache: fix cache regressions"
prs: 11086
issues: 10570
---
This update addresses two bugs in the evaluation cache system:
1. Regression in #10570: The evaluation cache was not being persisted in `nix develop` because `evalCaches` retained references to the caches and was never freed.
2. Nix could sometimes try to commit the evaluation cache SQLite transaction without there being an active transaction, resulting in non-error errors being printed.
These bug fixes ensure that the evaluation cache is correctly managed and errors are appropriately handled.
Author: [**Lexi Mattick (@kognise)**](https://github.com/kognise)