diff --git a/src/libexpr/eval-cache.cc b/src/libexpr/eval-cache.cc index 5b238bddb..5491f5d4c 100644 --- a/src/libexpr/eval-cache.cc +++ b/src/libexpr/eval-cache.cc @@ -423,7 +423,7 @@ void AttrCursor::fetchCachedValue() if (!cachedValue) cachedValue = root->db->getAttr(getKey()); if (cachedValue && std::get_if(&cachedValue->second) && parent) - throw CachedEvalError(ref(parent->first), parent->second); + throw CachedEvalError(parent->first, parent->second); } std::vector AttrCursor::getAttrPath() const @@ -508,7 +508,7 @@ std::shared_ptr AttrCursor::maybeGetAttr(Symbol name) if (auto attrs = std::get_if>(&cachedValue->second)) { for (auto & attr : *attrs) if (attr == name) - return std::make_shared(root, std::make_pair(shared_from_this(), attr)); + return std::make_shared(root, std::make_pair(ref(shared_from_this()), attr)); return nullptr; } else if (std::get_if(&cachedValue->second)) { auto attr = root->db->getAttr({cachedValue->first, name}); @@ -519,7 +519,7 @@ std::shared_ptr AttrCursor::maybeGetAttr(Symbol name) throw CachedEvalError(ref(shared_from_this()), name); else return std::make_shared(root, - std::make_pair(shared_from_this(), name), nullptr, std::move(attr)); + std::make_pair(ref(shared_from_this()), name), nullptr, std::move(attr)); } // Incomplete attrset, so need to fall thru and // evaluate to see whether 'name' exists @@ -554,7 +554,7 @@ std::shared_ptr AttrCursor::maybeGetAttr(Symbol name) } return make_ref( - root, std::make_pair(shared_from_this(), name), attr->value, std::move(cachedValue2)); + root, std::make_pair(ref(shared_from_this()), name), attr->value, std::move(cachedValue2)); } std::shared_ptr AttrCursor::maybeGetAttr(std::string_view name) diff --git a/src/libexpr/include/nix/eval-cache.hh b/src/libexpr/include/nix/eval-cache.hh index 4dd2e0332..2d70aa99e 100644 --- a/src/libexpr/include/nix/eval-cache.hh +++ b/src/libexpr/include/nix/eval-cache.hh @@ -90,7 +90,7 @@ class AttrCursor : public std::enable_shared_from_this friend struct CachedEvalError; ref root; - typedef std::optional, Symbol>> Parent; + using Parent = std::optional, Symbol>>; Parent parent; RootValue _value; std::optional> cachedValue;