mirror of
https://github.com/NixOS/nix
synced 2025-07-10 04:43:53 +02:00
Check the CA hash when importing stuff in the local store
When adding a path to the local store (via `LocalStore::addToStore`), ensure that the `ca` field of the provided `ValidPathInfo` does indeed correspond to the content of the path. Otherwise any untrusted user (or any binary cache) can add arbitrary content-addressed paths to the store (as content-addressed paths don’t need a signature).
This commit is contained in:
parent
48396d940e
commit
5985b8b527
4 changed files with 109 additions and 0 deletions
|
@ -11,6 +11,7 @@ nix_tests = \
|
|||
timeout.sh secure-drv-outputs.sh nix-channel.sh \
|
||||
multiple-outputs.sh import-derivation.sh fetchurl.sh optimise-store.sh \
|
||||
binary-cache.sh \
|
||||
substitute-with-invalid-ca.sh \
|
||||
binary-cache-build-remote.sh \
|
||||
nix-profile.sh repair.sh dump-db.sh case-hack.sh \
|
||||
check-reqs.sh pass-as-file.sh tarball.sh restricted.sh \
|
||||
|
|
38
tests/substitute-with-invalid-ca.sh
Normal file
38
tests/substitute-with-invalid-ca.sh
Normal file
|
@ -0,0 +1,38 @@
|
|||
source common.sh
|
||||
|
||||
BINARY_CACHE=file://$cacheDir
|
||||
|
||||
getHash() {
|
||||
basename "$1" | cut -d '-' -f 1
|
||||
}
|
||||
getRemoteNarInfo () {
|
||||
echo "$cacheDir/$(getHash "$1").narinfo"
|
||||
}
|
||||
|
||||
cat <<EOF > $TEST_HOME/good.txt
|
||||
I’m a good path
|
||||
EOF
|
||||
|
||||
cat <<EOF > $TEST_HOME/bad.txt
|
||||
I’m a bad path
|
||||
EOF
|
||||
|
||||
good=$(nix-store --add $TEST_HOME/good.txt)
|
||||
bad=$(nix-store --add $TEST_HOME/bad.txt)
|
||||
nix copy --to "$BINARY_CACHE" "$good"
|
||||
nix copy --to "$BINARY_CACHE" "$bad"
|
||||
nix-collect-garbage >/dev/null 2>&1
|
||||
|
||||
# Falsifying the narinfo file for '$good'
|
||||
goodPathNarInfo=$(getRemoteNarInfo "$good")
|
||||
badPathNarInfo=$(getRemoteNarInfo "$bad")
|
||||
for fieldName in URL FileHash FileSize NarHash NarSize; do
|
||||
sed -i "/^$fieldName/d" "$goodPathNarInfo"
|
||||
grep -E "^$fieldName" "$badPathNarInfo" >> "$goodPathNarInfo"
|
||||
done
|
||||
|
||||
# Copying back '$good' from the binary cache. This should fail as it is
|
||||
# corrupted
|
||||
if nix copy --from "$BINARY_CACHE" "$good"; then
|
||||
fail "Importing a path with a wrong CA field should fail"
|
||||
fi
|
Loading…
Add table
Add a link
Reference in a new issue