From 428a3e8cc84eac46614a45e5e48ec81fb1cfc72e Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 10 Feb 2025 16:18:57 +0100 Subject: [PATCH] Add TODO --- src/libfetchers/git-lfs-fetch.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libfetchers/git-lfs-fetch.cc b/src/libfetchers/git-lfs-fetch.cc index e9b690f8f..bc61fe292 100644 --- a/src/libfetchers/git-lfs-fetch.cc +++ b/src/libfetchers/git-lfs-fetch.cc @@ -19,6 +19,8 @@ namespace nix::lfs { static void downloadToSink( const std::string & url, const std::string & authHeader, + // FIXME: passing a StringSink is superfluous, we may as well + // return a string. Or use an abstract Sink for streaming. StringSink & sink, std::string sha256Expected, size_t sizeExpected)