wroclaw-git-backups/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-06-28 17:51:15 +02:00
Code Activity

ca-fd-leak: fix various unsafe c handling

Browse source
This commit is contained in:
Jörg Thalheim 2024-12-16 12:07:35 +00:00
parent eda331e53f
commit 3392a96901
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/nixos/ca-fd-leak/smuggler.c
View file

@ -16,7 +16,7 @@ int main(int argc, char **argv) {
struct sockaddr_un data; struct sockaddr_un data;
data.sun_family = AF_UNIX; data.sun_family = AF_UNIX;
data.sun_path[0] = 0; data.sun_path[0] = 0;
strcpy(data.sun_path + 1, argv[1]); strncpy(data.sun_path + 1, argv[1], sizeof(data.sun_path) - 1);
int res = bind(sock, (const struct sockaddr *)&data, int res = bind(sock, (const struct sockaddr *)&data,
offsetof(struct sockaddr_un, sun_path) offsetof(struct sockaddr_un, sun_path)
+ strlen(argv[1]) + strlen(argv[1])
@ -57,10 +57,11 @@ int main(int argc, char **argv) {
// Wait for a second connection, which will tell us that the build is // Wait for a second connection, which will tell us that the build is
// done // done
a = accept(sock, 0, 0); a = accept(sock, 0, 0);
if (a < 0) perror("accept");
fprintf(stderr, "%s\n", "Got a second connection, rewriting the file"); fprintf(stderr, "%s\n", "Got a second connection, rewriting the file");
// Write a new content to the file // Write a new content to the file
if (ftruncate(smuggling_fd, 0)) perror("ftruncate"); if (ftruncate(smuggling_fd, 0)) perror("ftruncate");
char * new_content = "Pwned\n"; const char * new_content = "Pwned\n";
int written_bytes = write(smuggling_fd, new_content, strlen(new_content)); int written_bytes = write(smuggling_fd, new_content, strlen(new_content));
if (written_bytes != strlen(new_content)) perror("write"); if (written_bytes != strlen(new_content)) perror("write");
} }