From 2b4d461c14e01eb86f5b253e7df93c595f45f52e Mon Sep 17 00:00:00 2001
From: Robert Hensing <robert@roberthensing.nl>
Date: Sat, 18 Jan 2025 09:58:17 +0100
Subject: [PATCH] checkRefs: use concatMapStringsSep

---
 src/libstore/unix/build/local-derivation-goal.cc | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/libstore/unix/build/local-derivation-goal.cc b/src/libstore/unix/build/local-derivation-goal.cc
index ca6348d6f..859663b68 100644
--- a/src/libstore/unix/build/local-derivation-goal.cc
+++ b/src/libstore/unix/build/local-derivation-goal.cc
@@ -2992,15 +2992,10 @@ void LocalDerivationGoal::checkOutputs(const std::map<std::string, ValidPathInfo
                     else if (auto output = get(outputs, i))
                         spec.insert(output->path);
                     else {
-                        std::string allOutputs;
-                        for (auto & o : outputs) {
-                            if (! allOutputs.empty())
-                                allOutputs.append(", ");
-                            allOutputs.append(o.first);
-                        }
+                        std::string outputsListing = concatMapStringsSep(", ", outputs, [](auto & o) { return o.first; });
                         throw BuildError("derivation '%s' output check for '%s' contains an illegal reference specifier '%s',"
                             " expected store path or output name (one of [%s])",
-                            worker.store.printStorePath(drvPath), outputName, i, allOutputs);
+                            worker.store.printStorePath(drvPath), outputName, i, outputsListing);
                     }
                 }