1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2025-06-27 00:11:17 +02:00

Add a dummy Store::buildPaths() method

This default implementation of buildPaths() does nothing if all
requested paths are already valid, and throws an "unsupported
operation" error otherwise. This fixes a regression introduced by
c30330df6f in binary cache and legacy
SSH stores.
This commit is contained in:
Eelco Dolstra 2017-05-01 13:43:34 +02:00
parent b0b81b7500
commit 0dddcf867a
No known key found for this signature in database
GPG key ID: 8170B4726D7198DE
5 changed files with 36 additions and 38 deletions

View file

@ -27,8 +27,6 @@ protected:
BinaryCacheStore(const Params & params);
[[noreturn]] void notImpl();
public:
virtual bool fileExists(const std::string & path) = 0;
@ -65,7 +63,7 @@ public:
bool isValidPathUncached(const Path & path) override;
PathSet queryAllValidPaths() override
{ notImpl(); }
{ unsupported(); }
void queryPathInfoUncached(const Path & path,
std::function<void(std::shared_ptr<ValidPathInfo>)> success,
@ -73,16 +71,16 @@ public:
void queryReferrers(const Path & path,
PathSet & referrers) override
{ notImpl(); }
{ unsupported(); }
PathSet queryDerivationOutputs(const Path & path) override
{ notImpl(); }
{ unsupported(); }
StringSet queryDerivationOutputNames(const Path & path) override
{ notImpl(); }
{ unsupported(); }
Path queryPathFromHashPart(const string & hashPart) override
{ notImpl(); }
{ unsupported(); }
bool wantMassQuery() override { return wantMassQuery_; }
@ -99,32 +97,29 @@ public:
void narFromPath(const Path & path, Sink & sink) override;
void buildPaths(const PathSet & paths, BuildMode buildMode) override
{ notImpl(); }
BuildResult buildDerivation(const Path & drvPath, const BasicDerivation & drv,
BuildMode buildMode) override
{ notImpl(); }
{ unsupported(); }
void ensurePath(const Path & path) override
{ notImpl(); }
{ unsupported(); }
void addTempRoot(const Path & path) override
{ notImpl(); }
{ unsupported(); }
void addIndirectRoot(const Path & path) override
{ notImpl(); }
{ unsupported(); }
Roots findRoots() override
{ notImpl(); }
{ unsupported(); }
void collectGarbage(const GCOptions & options, GCResults & results) override
{ notImpl(); }
{ unsupported(); }
ref<FSAccessor> getFSAccessor() override;
void addSignatures(const Path & storePath, const StringSet & sigs) override
{ notImpl(); }
{ unsupported(); }
std::shared_ptr<std::string> getBuildLog(const Path & path) override;