Wroclaw/WorkshopTasker
2
1
Fork 1
Code Issues Pull requests Activity Actions

Compare commits

base: Wroclaw:ccbbfd1d3b69458919570f57a0efc2f86675e427
Branches Tags
Wroclaw:main
Wroclaw:college/4/bazy_danych
...
compare: Wroclaw:500a9ad59505c7b9d005b36e5f0c4b59d390332c
Branches Tags
Wroclaw:main
Wroclaw:college/4/bazy_danych

2 commits
ccbbfd1d3b ... 500a9ad595

Author SHA1 Message Date
Wroclaw
500a9ad595 page/client: Don't default form to undefined.
All checks were successful
Build dev / build (push) Successful in 52s
Details 
This fixes an issue when user does not click the form field.
it is not being defined, meaning the field will not be updated.
 2023-11-09 11:39:00 +01:00
Wroclaw
f5b205f90c api/clients.post (checkIsClient): Fix opposite condition for the patch parameter. 
previously, when patch was true, it was requiring the values in the fields.
and vice versa.
It turns out the "patch" variable was negated for some reason.
 2023-11-09 11:39:00 +01:00
2 changed files with 8 additions and 8 deletions
Show stats Expand all files Collapse all files

8
pages/client/[id].vue
View file

@ -55,10 +55,10 @@ function updatePagedListVModel(element: Array<string>) {
const editMode = ref<boolean>(route.query?.edit === "1"); const editMode = ref<boolean>(route.query?.edit === "1");
function editorFields(): Array<fieldDefinition> { function editorFields(): Array<fieldDefinition> {
return [ return [
{ key: "name", type: "text", label: "Name", value: client.value.name ?? undefined }, { key: "name", type: "text", label: "Name", value: client.value.name ?? "" },
{ key: "address", type: "text", label: "Address", value: client.value.address ?? undefined }, { key: "address", type: "text", label: "Address", value: client.value.address ?? "" },
{ key: "phone", type: "text", label: "Phone", value: client.value.phone ?? undefined }, { key: "phone", type: "text", label: "Phone", value: client.value.phone ?? "" },
{ key: "email", type: "text", label: "E-mail", value: client.value.email ?? undefined }, { key: "email", type: "text", label: "E-mail", value: client.value.email ?? "" },
]; ];
} }

8
server/api/clients.post.ts
View file

@ -28,10 +28,10 @@ export function checkIsClient<Patch extends boolean = boolean>(
}); });
} }
if (!(typeof value.name === "string" || value.name === null || (!patch && value.name === undefined))) errors.set("name", "is not string or null"); if (!(typeof value.name === "string" || value.name === null || (patch && value.name === undefined))) errors.set("name", "is not string or null");
if (!(typeof value.address === "string" || value.address === null || (!patch && value.address === undefined))) errors.set("address", "is not string or null"); if (!(typeof value.address === "string" || value.address === null || (patch && value.address === undefined))) errors.set("address", "is not string or null");
if (!(typeof value.phone === "string" || value.phone === null || (!patch && value.phone === undefined))) errors.set("phone", "is not string or null"); if (!(typeof value.phone === "string" || value.phone === null || (patch && value.phone === undefined))) errors.set("phone", "is not string or null");
if (!(typeof value.email === "string" || value.email === null || (!patch && value.email === undefined))) errors.set("email", "is not string or null"); if (!(typeof value.email === "string" || value.email === null || (patch && value.email === undefined))) errors.set("email", "is not string or null");
for (const i in value as Partial<Omit<Client, "id">>) for (const i in value as Partial<Omit<Client, "id">>)
if (!clientKeys.includes(i)) errors.set(i, `excessive property`); if (!clientKeys.includes(i)) errors.set(i, `excessive property`);